> Yes, it looks sane. I can make some remarks about the code but they are
> minor:
>
>   - You initialise both h and k outside the loop, there is no need, you can
> remove that definition and the code will work the same.

I removed these initialisations.

>  - The code is inefficient, it will run over all lines even if you don't have
> any table in the document. Again this can be changed later if the profiler
> shows that there is a significant lag do to this code.

How could this be done better?

>  So regarding the lyx2lyx part the code is OK, so this can go in.

It's in:
http://www.lyx.org/trac/changeset/18052

regards Uwe

Reply via email to