Abdelrazak Younes wrote:
Abdelrazak Younes wrote:
Mostafa Vahedi wrote:
> b) The current code in the method "Paragraph::transformChar" has
a bug,
> when the prev_char is a COMPOSE character (such as FATHA) and the
previous BASE character is a SPECIAL character (such as ALEF). In
this case the current character (such as BAA) gets the medial form
and gets connected to the previous SPECIAL character which is not
correct. The correct way to handle this situation is that, similar
to the next_char, the first previous non-COMPOSE character should be
assigned to the prev_char if exists.
>
Any progress with this, Mostafa? I don't know the transformChar
code,
but it sounds like the changes you're suggesting shouldn't be too
hard...? If I can help out in any way, I'd be happy to try...
It is attached.
Hello Mostafa,
The patch looks good. Does it solves all use cases for you?
By the way, if you use svn, "svn diff" is a better way to generate a
patch. As it is, your patch cannot be applied without editing.
Here is the patch against latest svn. Dov, could you confirm that it
works fine?
Abdel.
Hi!
Yes, it works, and looks good --- it should go in, as far as I'm
concerned. Good work, Mostafa! :)
I do have some questions, though:
1) Can anyone recommend a screenfont (Linux/X11) which has glyphs for
the points (FATHA, etc.) --- the font I'm currently using just shows a
box...
2) The current Arabic keymap lib/kbd/arabic.kmap doesn't provide the
points, as far as I can see. Is this because it follows a standard
layout, but the standard doesn't provide them? Is there a standard
layout which we could follow which would allow us to add these?
Thanks!
Dov
