Abdelrazak Younes wrote: > > [1] Ideally, it should grab what is defined for "command-execute" and use > > that. But I don't know how to get that information from the frontend > > side. > > I don't understand what you mean here. Please clarify.
It's hardcoded to M-x for closing. If someone changes the shortcut for "command-execute" in the bind-file to something else, opening and closing the minibuffer will have different shortcuts. Ideally, if the shortcut for opening is customized, the one for closing should be adapted likewise. > Some comments below: > > Index: src/frontends/qt4/QCommandBuffer.h > > =================================================================== > > --- src/frontends/qt4/QCommandBuffer.h (Revision 18054) > > +++ src/frontends/qt4/QCommandBuffer.h (Arbeitskopie) > > @@ -43,6 +43,8 @@ > > void up(); > > /// down > > void down(); > > + /// leave and hide the command buffer > > + void hideCommandBuffer(); > > hide() is good enough. We already know that we are using the command > buffer. but this interferes with Qt::widget->hide(). > But instead of continuing those hacks in the minibuffer and > reimplementing a toolbar in a widget, why not making it a toolbar > proper? It should not be very hard but maybe not 1.5.0 stuff though... I agree, but I think it's not 1.5. stuff. My solution is easy to implement and it's not too hackish IMHO. > Abdel. Jürgen
