Bo Peng wrote:
Dear all,
Attached please find a much improved InsetListings patch. The
implementation can now be reviewed...
Changes:
Better organized InsetListingsParams functions
Autotools support
InsetListings now derives from InsetERT
Use LISTINS_CODE
Code cleaning
and more...
Looks much cleaner indeed.
I propose a deal ;-) :
You promise to fix all remaining issues (if any) WRT your features and
then this feature can go in (AFAIAC of course). Straight out of my head,
here are some bugs related to your work:
- reported session crash with cursor in collapsable inset (if not
already solved)
- cursor jumping from beginning to current position upon buffer-switching
- bug 3488. Maybe not yours but you'll probably have an idea. Maybe the
same as the first item.
Abdel.
