>>>>> "Edwin" == Leuven, E <[EMAIL PROTECTED]> writes:
>> My proposal is (still) to revert 17837 Bo's patch make the document >> (changed) when an inset is toggled (since this changes the >> information in the file). However, when done on a read-only file, >> this creates very buggy situations. Edwin> and it is very annoying that a document gets marked dirty when Edwin> the content didn't change Edwin> so i for one would welcome this... Indeed, it is possible to force a document to become dirty, but not to make it clean again. Two solutions: 1/ revert Bo's patch 2/ apply the patch below, that makes the document dirty only when it is not read-only. Jose? JMarc
Index: src/insets/InsetCollapsable.cpp =================================================================== --- src/insets/InsetCollapsable.cpp (révision 18240) +++ src/insets/InsetCollapsable.cpp (copie de travail) @@ -444,7 +444,8 @@ void InsetCollapsable::setStatus(Cursor cur.leaveInset(*this); // Because we save CollapseStatus in lyx file, change of status // should lead to a dirty buffer. (This fixes bug 2993). - cur.bv().buffer()->markDirty(); + if (!cur.bv().buffer()->isReadonly()) + cur.bv().buffer()->markDirty(); }
