Thanks, sir. But I have one more patch. I had a look at the usage of the
browse function through lyx, and saw QExternal.cpp needs the same patch. The
patch for that dialog is attached.
Well, I have no intention to leave lyx development. I will keep coding as
much as I can. However, I still feel as a newbie on the code. That is why I
did not asked svn access and that is also why I ask confirmation for every
single patch I send. But you are right, at least for such trivial patches I
can submit to svn with confidence. I will ask JMarc for svn access for such
small fixes.
Thanks for the compliments, sir :)
Ugras
PS. I guess it is safe to close the bug 3377. I couldn't find a bugzilla
entry for QExternal bug.
On 5/11/07, Abdelrazak Younes <[EMAIL PROTECTED]> wrote:
Ozgur Ugras BARAN wrote:
> Attached trivial patch solves Bug 3377 (In insert graphic window:
> canceling open dialog erases entry in text box). This bug is not Mac
> specific, but exist in Linux. (should exist in other OSes).
>
> Please may somebody apply the patch?
Done.
Ugras, if you plan to stay with us (and I hope you will). Please ask
commit access to JMarc. Tell him that you already contributed a number
of fixes and features and that you are a serious, responsible guy.
Abdel.
--- QExternal.cpp (revision 18067)
+++ QExternal.cpp (working copy)
@@ -187,8 +187,10 @@
docstring const str =
form_->controller().browse(qstring_to_ucs4(fileED->text()),
template_name);
- fileED->setText(toqstr(str));
- form_->changed();
+ if(!str.empty()) {
+ fileED->setText(toqstr(str));
+ form_->changed();
+ }
}
