José Matos wrote:
>> Richard> The attached patch partially addresses this bug. Not
>> Richard> completely, because it only checks if a file is including
>> Richard> itself and not if a file includes a file that includes it
>> Richard> (etc). The places where the more general check would need to
>> Richard> be done are identified with FIXME RECURSIVE INPUT so that
>> Richard> this can be done later, but I don't have any sense what to do
>> Richard> here, and it's not a terribly common issue, so I'm not going
>> Richard> to pursue it now.
>>
>> This looks good, except for tabs in the snippet below (before the bformat):
>>
>> + //Check we're not trying to include ourselves.
>> + //FIXME RECURSIVE INCLUDE
>> + //This isn't sufficient, as the inclusion could be downstream.
>> + //But it'll have to do for now.
>> + if (buffer.fileName() == included_file.toFilesystemEncoding()) {
>> + Alert::error(_("Recursive input"),
>> +
>> bformat(_("Attempted to include file %1$s in itself! "
>> +
>> "Ignoring inclusion."), from_utf8(incfile)));
>>
>
> Is this in?
>
Yes, at 18445.
rh
--
==================================================================
Richard G Heck, Jr
Professor of Philosophy
Brown University
http://frege.brown.edu/heck/
==================================================================
Get my public key from http://sks.keyserver.penguin.de
Hash: 0x1DE91F1E66FFBDEC
Learn how to sign your email using Thunderbird and GnuPG at:
http://dudu.dyn.2-h.org/nist/gpg-enigmail-howto
