Jean-Marc Lasgouttes wrote:
"Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes:
Dov> Hi! I haven't gotten any responses to the patch I sent in
Dov> yesterday, so I took the opportunity to open a bug for this in
Dov> bugzilla (http://bugzilla.lyx.org/show_bug.cgi?id=3811).
Dov> There are explanations there regarding the patch (which is also
Dov> attached here). Please make sure it makes sense, and if so ---
Dov> could someone please commit?
The patch looks good to me. One question: what about the other call to
translateAndInsert (for the accent lfuns)? Shouldn't it get a
switchKeymap too?
I imagine it should, too. Is the keymap really actually used for the
accents? How does one insert an accent? Perhaps the accent lfuns should
actually call (dispatch?) the SELF_INSERT lfun, instead of inserting the
accent character themselves? I don't use accents, so I really don't
know about this...
Am I right that switchKeyMap assumes that the primary keymap is ltr
and the secondary rtl? This is ugly.
It looks like it (but I'm sure you know this code at least as well as I
do, I only just looked at it for the first time when trying to solve
this issue, and I didn't look too deeply then, either)... and yes, it's
not great. It would be nice (especially for when we'll want to get
Hebrew + English + Arabic working, for example) to be able to have many
keymaps. But this is really a separate issue from the current one, and
shouldn't hold this up for now...
JMarc
