Marko> current CVS does not compile with KDE frontend due to the difference in
Marko> Dialogs class definition for KDE and Xforms frontends. Namely, Dialogs
Marko> class constructor expects LyXView* as its argument in Xforms frontend
Marko> (src/frontends/Dialogs.h src/frontends/xforms/Dialogs.C) and LyXFunc* as
Marko> an argument in KDE frontend (src/frontends/kde/Dialogs.C).

Marko,
all development has been done with the xforms code. The code in the kde
directory was written as proof of concept a long, long time ago. As such, it
has lagged behind...

You are correct to report that the code in kde/Dialogs.C is inconsistent with
that in xforms/Dialogs.C. It is wrong and should be

Dialogs::Dialogs(LyXView * lv)
{
        dialogs_.push_back(new FormCopyright(lv, this));
        dialogs_.push_back(new FormPrint(lv, this));
        dialogs_.push_back(new FormPreferences(lv, this));

        // reduce the number of connections needed in
        // dialogs by a simple connection here.
        hideAll.connect(hideBufferDependent.slot());
}

Note, however, that this code won't compile either as no Print and
Preferences dialogs for kde. Commenting them out will allow the code to compile
(and maybe even link??) but the resulting executable will not have these
dialogs. Seems a bit pointless, no?

If, of course, you wish to write the missing dialogs...

Angus

Reply via email to