On Mon, Jun 18, 2007 at 02:09:34PM +0200, Abdelrazak Younes wrote:
> Enrico Forestieri wrote:
> > On Mon, Jun 18, 2007 at 12:06:50PM +0200, Leuven, E. wrote:
> >
> >> --- src/frontends/qt4/IconPalette.h (revision 18812)
> >> +++ src/frontends/qt4/IconPalette.h (working copy)
> >> @@ -20,7 +20,7 @@
> >> // FIXME: this can go when we move to Qt 4.3
> >> #define QT_VERSION_CHECK(major, minor, patch)
> >> ((major<<16)|(minor<<8)|(patch))
> >>
> >> -#if QT_VERSION >= QT_VERSION_CHECK(4, 2, 0)
> >> +#if QT_VERSION >= QT_VERSION_CHECK(4, 2, 0) && !Q_WS_MACX
> >> #include <QWidgetAction>
> >> #endif
> >
> > Edwin, moc doesn't perform like the preprocessor. It doesn't parse
> > included files, such that QT_VERSION is undefined, and doesn't
> > understand macros. In the check above, moc chooses randomly one
> > branch or another. See what I wrote in the thread "tear-off math panel".
>
> I think there are two solutions:
> 1) require Qt4.2
While tearing away math panels maybe a nice feature, it is not essential,
so requiring Qt4.2 only for that is a lame excuse, IMHO. This is so also
for the requirement of Qt4.1 minimum, as it is only dictated by the
syntax highlighting thing. This is only mitigated by the fact that
Qt4.0 was somewhat buggy. On the contrary, Qt4.1 is a quite good version.
> 2) Modify the build system(s) to selectively compile
> IconPalette_42.{h,cpp} when Qt >= 4.2 is detected and
> IconPalette.{h,cpp} otherwise.
>
> As 1) is not an option for some of us the only solution is 2).
Maybe. Let's see what our experts are able to do. Personally, I don't
have any problem with whatever version is required.
--
Enrico
