On 21-Jun-2000 Dekel Tsur wrote:
> On Wed, Jun 21, 2000 at 09:10:15AM +0200, Juergen Vigna wrote:
>>
>> I've had a look at the patch and it seems good, but I've a question, what
>> means when you set the language to ignore_language, is that the Reset?
>
> Setting to ignore_language means that we don't want to change the language
> of text (we are changing other properties).
>
I still don't understand why you need this call ???
>> But then I don't understand the second set: params.language_info,
>> I thought that if we Reset the language info it should be ignored and
>> automatically the language of the document should be used. I would like
>> to hear your thoughts about this before applying it.
>
> The language property behaves differently than other font properties:
> it is not inherited from the layout/lower depth paragraphs, and there is no
> language_inherit.
> In other words, if we have a document with the text "abc DEF ghi" where
> "DEF" is bold, and the rest is default font, than we store "DEF" with
> BOLD_SERIES attribute, and the rest with INHERIT_SERIES attribute.
> However, if have a French document, with the text "abc DEF ghi" where "DEF"
> is English, and the rest is French, then we store "DEF" with "english"
> language attribute, and the rest is stored with "french" language attribute
> (and not "inherit").
>
Ok I see, I added your patch and will commit it right away!
>> > PS The font changing commands work correctly inside the footnote inset.
>>
>> Good! What about the Cursor?
>
> I can't try it now as the changes you made today to the CVS made the
> tabular/text insets to function improperly.
You're right but I wanted to commit it so that Lars and others could look
at the code and comment. You're right the update does not really work now
so if we have a repaint it does not work, but just moving a cursor should
work as we don't have arepaint there!
> Moreover,
> 1. The line "clear_area = row_ptr->par()->GetInset(row_ptr->pos())->doClearArea();"
> in LyXText::GetVisibleRow causes error messages when GetVisibleRow is called
> normally for a text without an inset.
>
Why shouldn't this not work??? I call that only if :
(row_ptr->par()->GetInset(row_ptr->pos()) != 0)
so there is an inset there where I can call this function!
> 2. You forgot to change the draw() method to the formula inset.
Yes and also the GetCursorPos() function. I'll fix this and commit it
with your patch NOW :)
Jürgen
--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED]
Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450296
I-39100 Bozen Web: http://www.sad.it/~jug
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
What we see depends on mainly what we look for.
-- John Lubbock
