perhaps this can make it into rc2?
Richard Heck wrote:
The attached patch deals with most of the remaining issues with the
Paragraph Settings dialog, after the long discussion about how to do it.
I've redesigned the dialog itself in accord with some ideas of Edwin's,
adapting also some suggestions of Helge's. A screenshot is attached.
This separates out "Default" a bit, changes the label to "Default for
Current Paragraph"---I think that makes it a little clearer to users
what this does---and makes some space for adding "(Justifed)" without
alignment issues.
Something even better, in the non-multi-paragraph case, might be to make
it say "Default for Standard" or "Default for Itemize" or whatever. But
I think doing this will involve rather more work, as the extant
controller doesn't provide access to this.
There is one remaining issue, namely, that what the default is isn't
indicated here, because I haven't had time to figure out how to
determine if there is a multi-paragraph selection. And, fortunately, for
me, I'm going on vacation for a week and a half on Thursday and am very
unlikely to be able to do that before then. So I'm hoping someone else
will finish that bit---Abdel, JMarc? The only thing that needs doing is
to replace the silly:
bool const isMultiParagraph = false;
in QParagraphDialog::checkAlignmentRadioButtons() with something
sensible. The other needed code is already there.
Also, there are a couple "FIXME"s here that refer to the fact that
LYX_ALIGN_LAYOUT isn't required to be a possible alignment. Obviously,
it should be. The second patch I've attached makes this change---and
another one, namely: Why should LYX_ALIGN_BLOCK be possible by default?
No good reason, so far as I can see. With this, the two FIXMEs can be
fixed (and I think a proper solution for some other bugs also comes into
sight, but later). If anyone wants to sort this out, too, that'd be great.
I can commit all of this later tonight if someone tells me how to deal
with the multi-paragraph bit. Or someone can fix that and commit it for
me. I don't care. Either way.
Richard
------------------------------------------------------------------------
