>>>>> "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes:

Dov> Hi! Attached find a patch fixing
Dov> http://bugzilla.lyx.org/show_bug.cgi?id=3959 (which I just opened
Dov> tonight).

Dov> Please note that there appears to have been an attempt to
Dov> explicitly do the opposite of what I'm trying to do here, though
Dov> for different reasons, I think: r10808, which fixed bug 2115. I'm
Dov> not sure if what I'm trying to fix here is a necessary
Dov> consequence of that fix, but I certainly consider the current
Dov> behavior which the current patch fixes buggy.

The patch does not look wrong to me. 

Dov> Specifically, what I'm doing here is going to override what's
Dov> being done in the InsetText constructor; but I'm not getting rid
Dov> of that, because there still may be times when the constructor is
Dov> called, from elsewhere...

I'd appreciate if you could try to track down the uses of this
constructor and see if this overriding could be avoided. This font
stuff is already intimidating, and we probably do not need another
level of weirdness :)

Dov> My patch still doesn't handle Tables. I think the language of
Dov> tables should be set to the current language, as well. Any help
Dov> is welcome.

Indeed. This is where working at insettext constructor level would
maybe help (of course, at this point one does not know the font, so
doing it as you do seems good).

JMarc

Reply via email to