Enrico Forestieri <[EMAIL PROTECTED]> writes:

>> +[lyx_major=`echo $PACKAGE_VERSION | sed -e 's/[[.]].*//'`
>> + lyx_minor=`echo $PACKAGE_VERSION | sed -e "s/^$lyx_major//" -e 's/^.//'`
>> + lyx_release=$lyx_minor
>> + lyx_minor=`echo $lyx_release | sed -e 's/[[.]].*//'`
>> + lyx_release=`echo $lyx_release | sed -e "s/^$lyx_minor//" -e 's/^.//'`
>> + lyx_patch=$lyx_release
>> + lyx_release=`echo $lyx_patch | sed -e 's/[[^0-9]].*//'`
>> + lyx_patch=`echo $lyx_patch | sed -e "s/^$lyx_release//" -e 's/^[[.]]//' -e 
>> 's/[[^0-9]].*//'`
>> 
>> At least lines 2 and 3 do not look right.
>
> Please, explain what doesn't look right. 

I would replace lines 2 and 3 by 
>> + lyx_release=`echo $PACKAGE_VERSION | sed -e "s/^$lyx_major//" -e 's/^.//'`
since the assignment to lyx_minor is not used.

Then I wondered whether other things could be problematic.

You can apply to trunk and branch.

JMarc

Reply via email to