Abdelrazak Younes <[EMAIL PROTECTED]> writes:
> Some cosmetic comments on the code (all IMHO):
>
> @@ -922,14 +928,31 @@ void TextClass::readCounter(Lexer & lexr
> switch (static_cast<CounterTags>(le)) {
> case CT_NAME:
> lexrc.next();
> - name = from_ascii(lexrc.getString());
> + name = lexrc.getDocString();
> + if (ctrs_->hasCounter(name))
>
> ctrs_ should be renamed to counters_ and the line above should be:
>
> + if (counters_->has(name))
>
> The same for ctrs_->newCounter() which could become counters_->new().
Isn't new a reserved word?
> In general I think that members should have explicit naming (I know
> this is not your doing).
Rather than doing that, I think I'd prefer to expose a map-like
interface. I agree however that each of our container-like has its own
special interface, and this is very annoying.
> Some of the new methods lacks doxygen comments. Also Lars said someday
> that we should standardize on a doxygen style ex:
I added some.
JMarc
