Uwe Stöhr wrote:
> Attached is a batch for bug 2907
> http://bugzilla.lyx.org/show_bug.cgi?id=2907
>
> It shows the index dialog like in LyX 1.3.x and previous.
>
> The code is stolen from LFUN_NOMENCL_INSERT and works as expected.
> If there are no objections, can this go into branch?
If any, I would prefer the attached patch the avoids redundancy.
However, I think this is the wrong approach: it opens the index dialog
unnecessarily (i.e., if the word-at-cursor is filled in, which is often the
desired behaviour, and closing the dialog each and every time is annoying).
Furthermore, it doesn't fix bug 2907: C-i still doesn't open the inset's
dialog. Do fix this (which also applies to url, nomenclature and others),
you'd need the change LFUN_NEXT_INSET_TOGGLE or LFUN_INSET_TOGGLE,
respectively. But then. you have to take care that all-insets-toggle doesn't
pop up the dialogs as well.
Jürgen
Index: src/Text3.cpp
===================================================================
--- src/Text3.cpp (Revision 20186)
+++ src/Text3.cpp (Arbeitskopie)
@@ -1298,11 +1298,14 @@
cur.clearSelection();
insertInset(cur, inset);
inset->edit(cur, true);
- // Show the dialog for the nomenclature entry, since the
+ // Show the dialog, since the
// description entry still needs to be filled in.
if (cmd.action == LFUN_NOMENCL_INSERT)
InsetCommandMailer("nomenclature",
*reinterpret_cast<InsetCommand *>(inset)).showDialog(&cur.bv());
+ else if (cmd.action == LFUN_INDEX_INSERT)
+ InsetCommandMailer("index",
+ *reinterpret_cast<InsetCommand *>(inset)).showDialog(&cur.bv());
cur.posRight();
break;
}
