Jean-Marc Lasgouttes schrieb:
[EMAIL PROTECTED] (Jürgen Spitzmüller) writes:

Jean-Marc Lasgouttes wrote:
I lost the patch. Where is it?
http://bugzilla.lyx.org/attachment.cgi?id=1959&action=view

I have not see this patch before actually.

Does the new libFileSearch have to build a vector<pair>>? We do not
really care about "user_lyxdir" and such identifiers, IMO.

This used is only for the message.

insist on keeping this, a map<string, FileName> would make more sense.

That was also my first thought when i implemented this method, but with that approach we lose the order of the entries, which is essential for the logic.

Other than that, this new function looks useful.

So the new behaviour would be to merge the three template files (BTW,
I am not sure the notion of build_dir is useful anymore,

I don't know that either but i added it because it is used in the other 
libFileSearch method too.

separate discussion). The code as it is written makes sense, but I do
not like outputting error messages to the console. They should be
turned into debug messages (if we keep them). Instead we could mark in
the GUI where each template comes from.

I think we need some kind of information for the user what is happening in this case, because if there is a problem because of one template hides another one the user should be able to find a hint about what's going on.

bernhard

Reply via email to