Pavel Sanda <[EMAIL PROTECTED]> writes:
> below is the patch polished according to the comments and i consider
> it to be the fix for 2739.
>
> i dropped on-top feature and will look on the suggestion above
> later and as separate issue. what do you think ?
Looks good. A few comments below.
> +void GuiLayoutBox::addSortItem(QString const & item, bool sorted)
The name is strange. I'd rather keep addItem if possible, or
addSortedItem or addItemSort. (this is a minor complaint...)
> + //set standard as default
> + setCurrentIndex(0);
I am not sure what you mean by this comment. do you mean "the default
layout" instead of "standard"?
> Index: src/LyXRC.cpp
> ===================================================================
> --- src/LyXRC.cpp (revision 21005)
> +++ src/LyXRC.cpp (working copy)
> @@ -106,6 +106,7 @@
> { "\\language_global_options", LyXRC::RC_LANGUAGE_GLOBAL_OPTIONS },
> { "\\language_package", LyXRC::RC_LANGUAGE_PACKAGE },
> { "\\language_use_babel", LyXRC::RC_LANGUAGE_USE_BABEL },
> + { "\\layouts_sorted", LyXRC::RC_LAYOUTS_SORTED },
To be more in line with other LyXRC entries, I'd really prefer \sort_layouts.
JMarc
