Enrico Forestieri <[EMAIL PROTECTED]> writes:
> That didn't help, but looking at the code I saw that the contents of
> PRL_EXPORT_DEFINES get output to pkg-config files. So, adding the line
>
> cygwin-g++-win32:PRL_EXPORT_DEFINES += Q_CYGWIN_WIN
>
> to qbase.pri did the trick!

Looking at the uses of Q_CYGWIN_WIN in our own code, I see two of them:

1/ in GuiApplication.cpp:

#ifdef Q_WS_WIN
#include <QWindowsMime>
#if defined(Q_CYGWIN_WIN) || defined(Q_CC_MINGW)
#include <wtypes.h>
#endif
#include <objidl.h>
#endif // Q_WS_WIN

We can use Q_OS_CYGWIN here, can't we? 

Why is the <wtypes.h> header needed BTW?

2/ in FileDialog.cpp

#if defined(Q_WS_MACX) || (defined(Q_WS_WIN) && !defined(Q_CYGWIN_WIN))
#define USE_NATIVE_FILEDIALOG 1
#endif

I think Q_OS_CYGWIN is OK here too.


The advantage of getting rid of Q_CYGWIN_WIN in our code is to make it
generic and not depend on your port (qt may be be ported to cygwin one
day, after all).

JMarc

Reply via email to