Pavel Sanda <sa...@lyx.org> writes:
>> Also, I'm not sure I understood this feature, but wouldn't a string such as 
>> "Lock File in Repository" be more adequate?
>
> No, because it doesn't lock anything. Locking is done by svn when
> updating/commiting and this command just tells svn that it should use
> this locking mechanism.

So you mean "Use Locking Property" ?

>>I do not like the verb "toggle" in 
>> the UI context. 
>
> Feel free to suggest better naming. We use it anyway in different UIs
> $ cat cs.po|grep -i toggle|grep -v ^#|wc -l
> 16

This kind of grepping is irrelevant. The question here is about menus.
>From the command
  grep -i -B1 '^msgid.*toggle' cs.po 
I see only three in menus:
--
#: lib/ui/classic.ui:159
msgid "Toggle Numbering|N"
--
#: lib/ui/classic.ui:160
msgid "Toggle Numbering of Line|u"
--
#: lib/ui/stdcontext.inc:133
msgid "Toggle Label|L"
--

Of these, only the last one is interesting, since we do not change
classic.ui anymore (although we may want to make them in line with default?)

This last one should changed to "Show Label", but I do not know how to
try it (it is for inset-conglomerate).

>>Also, I would use a menu checkbox (FuncFlags::setOnOff) that 
>> is checked if the file is locked. Then you'd have three states:
>
> No, this flag doesn't mean that the file is locked - we already check
> this and user can recognize locking status on window title or VC toolbar.

See above. The check box will be useful with changed name.

JMarc

Reply via email to