[email protected] wrote: > Author: vfr > Date: Sat Aug 15 01:12:21 2009 > New Revision: 31043 > URL: http://www.lyx.org/trac/changeset/31043 > > Log: > Extend saveBufferIsNeeded with a parameter indicating whether the buffer is > going into a hidden state. If so, and the user discards his changes, the > buffer will be reloaded to discard the changes. > > Now, the option "Hide Tab" uses closeBuffer and asks for saving intead of > instantly removing the workArea. > > This is part of bug #5893: we try to make sure that there are no dirty hidden > buffers.
have you checked its not dataloss from multiple windows view as i have warned before? if you have two windows, which have opened the same file and then try to hide buffer in one of the windows, you will ask for save. this imho shouldn't happen, secondly if hit don't save i get reload and lose my changes of this document in the second window? i haven't followed the whole thread but this feel wrong to me. it looks like crippling hide feature and introducing new bugs (i just got crash when trying the scenario outlined above) instead of fixing the real issue - triggering the dialog when the buffer get closed. pavel
