On 15/11/2009 23:21, Abdelrazak Younes wrote:
On 15/11/2009 23:16, Abdelrazak Younes wrote:
On 15/11/2009 22:39, Abdelrazak Younes wrote:
Hello Richard,

I don't know if you are interested in bug report but here are some anyway:

Next one:

XML Parsing Error: mismatched tag. Expected: </column>.
Location: file:///C:/devel/lyx/lyx-devel/lib/doc/EmbeddedObjects.xhtml
Line Number 6618, Column 3:</lyxtabular>
--^

This one looks a bit more complicate to solve...

It seems that the 'features' and 'column' tags are not properly closed in our own LyX format; this is a bug of the LyX format itself.

The attached patch fixes the format for me and the EmbeddedObject manual can still be saved and loaded with the old format. But I of course won't commit because this is a format change. I'll let you handle this because I am done for this week-end, unfortunately...

Abdel.

Index: insets/InsetTabular.cpp
===================================================================
--- insets/InsetTabular.cpp     (revision 32030)
+++ insets/InsetTabular.cpp     (working copy)
@@ -1343,14 +1343,14 @@
        if (is_long_tabular)
           os << write_attribute("longtabularalignment",
                                 longtabular_alignment);
-       os << ">\n";
+       os << "/>\n";
        for (col_type j = 0; j < column_info.size(); ++j) {
                os << "<column"
                   << write_attribute("alignment", column_info[j].alignment)
                   << write_attribute("valignment", column_info[j].valignment)
                   << write_attribute("width", 
column_info[j].p_width.asString())
                   << write_attribute("special", column_info[j].align_special)
-                  << ">\n";
+                  << "/>\n";
        }
        for (row_type i = 0; i < row_info.size(); ++i) {
                static const string def("default");
Index: tex2lyx/table.cpp
===================================================================
--- tex2lyx/table.cpp   (revision 32030)
+++ tex2lyx/table.cpp   (working copy)
@@ -1042,7 +1042,7 @@
        os << "<features"
           << write_attribute("rotate", false)
           << write_attribute("islongtable", is_long_tabular)
-          << ">\n";
+          << "/>\n";
 
        //cerr << "// after header\n";
        for (size_t col = 0; col < colinfo.size(); ++col) {
@@ -1054,7 +1054,7 @@
                   << write_attribute("rightline", colinfo[col].rightlines > 0)
                   << write_attribute("width", 
translate_len(colinfo[col].width))
                   << write_attribute("special", colinfo[col].special)
-                  << ">\n";
+                  << "/>\n";
        }
        //cerr << "// after cols\n";
 

Reply via email to