John McCabe-Dansted wrote: > Well, I in the attached (very draft) patch I have cut and pasted > feature (3) from GuiSpellChecker.cpp. It seems reasonable that the > user install spellchecker modules for languages they want permanently > in the Langauges menu. However converse it not true, as a user may be > using a public machine where all languages have been installed. To > deal with this I was thinking of limiting the languages added from the > spellchecker to code to say 12, using a menu separator to split off > from the languages actually used in the Document. Does this approach > sound reasonable?
I prefer the session approach. I often use languages for which I do not have a spell checker dictionary installed. And I do not want all languages for which I have a dictionary in the menu (I might have installed the dictionaries even for another app than LyX). > Also the attached patch I have sorted the language by name. I think > this makes the list easier to read, and also it makes your keyboard > accelerator code work better. E.g. with the new sorting code I get: > _English > English (_UK) > Rather than > _English (UK) > E_nglish > In general your shortcut code will work better if parent languages > appear before sub-languages: > _Language > Language (_Sublanguage) Yes, the sorting makes sense. > This patch also commented out the "if (languages.size() < 2)" code. I > recall that Lars didn't like dumping the user straight into the text > style dialog box, but I don't like the idea of graying out the > Languages dialog box, IMHO the user should always be able to set the > Language from Edit->Languages. No, we just removed that, and I think Jean-Marc put forward good reasons for this. Jürgen
