Le 10/03/2010 23:20, Abdelrazak Younes a écrit :
Well, it does modify the inset so it's OK to have it in there.
But I agree about the distinction beween inset-modify and
inset-params-modify. Basically inset-modify should be about modifying
the content (and can depend on the Cursor position) and
inset-params-modify should be about modifying the parameter of the
inset, without touching the contents.
Except that I am not sure that inset-modify will be able to have common
enough semantics to be a single function. In the furute,
inset-params-modify will just set the parameters like in the xml format:
inset-param-modify insetname param1=val1 param2=val2
and the code will be in one nice place, and be used also for file reading.
I do not see such a nice scheme emerging for your inset-modify.
A possibility would be to handle this in InsetTableCell::dispatch, but
I am not sure this make lots of sense.
I think it does.
The problem is that it modifies stuff outside of the cell itself.
JMarc
