>
>> Index: Systemcall.cpp
>> ===================================================================
>> --- Systemcall.cpp (Revision 34914)
>> +++ Systemcall.cpp (Arbeitskopie)
>> @@ -246,16 +246,24 @@
>> out_index_(0),
>> err_index_(0),
>> out_file_(of),
>> -
>> terminal_out_exists_(os::is_terminal(os::STDOUT)),
>> -
>> terminal_err_exists_(os::is_terminal(os::STDERR)),
>> + use_stdout_(false),
>> + use_stderr_(false),
>
> We can avoid initializing these two, given the change below.
Initializing to false is better than nothing.
>
>> process_events_(false)
>> {
>> if (!out_file_.empty()) {
>> + // Don't output to terminal if stdout is redirected
>> + use_stdout_ = false;
>> // Check whether we have to simply throw away the output.
>> if (out_file_ != os::nulldev())
>> process_->setStandardOutputFile(toqstr(out_file_));
>> + } else if (os::is_terminal(os::STDOUT)) {
>> + // Output to terminal if stdout exists and is not redirected
>> + use_stdout_ = true;
>
> } else {
> // Output to terminal if stdout exists and is not redirected
> use_stdout_ = os::is_terminal(os::STDOUT);
>
OK, commited.
Peter
