Stephan Witt wrote:
> It's used in SVN::checkOut() too.
> And it's the result of scanLogFile parser and not a filename.
> I think, the general problem is the switch from std::string to docstring and
> vice versa.
> It is std::string what is used for interface of VCS classes. but the alerts
> use docstrings...
i see.
> >> string CVS::revisionInfo(LyXVC::RevisionInfo const info)
> >> {
> >> - if (info == LyXVC::File)
> >> - return version_;
> >> + if (!version_.empty()) {
> >> + if (rev_author_cache_.empty()) {
> >> + if (!getRevisionInfo()) {
> >> + rev_author_cache_ = to_local8bit(_("unknown
> >> author"));
> >> + rev_date_cache_ = to_local8bit(_("unknown
> >> date"));
> >> + rev_time_cache_ = to_local8bit(_("unknown
> >> time"));
> >
> > this code breaks the current practise - either we return true value or empty
> > string in unknown case, which will be handled on the hierarchy above.
>
> > and i think i see latent translating bug in the handling code above. wanted
> > to
> > check it but why the hell LC_MESSAGES=cs_CZ src/lyx doesn't work anymore for
> > trunk...
>
> I'll use an explicit getRevisionInfo() success state flag and return string()
> instead. Ok?
not sure what exactly do you mean :)
pavel
