-------- Original-Nachricht --------
> Datum: Wed, 08 Dec 2010 16:05:39 -0500
> Von: Richard Heck <[email protected]>
> An: LyX Developers <[email protected]>
> Betreff: Error List Worry Re Asynchronous Export

> 
> This code:
> 
> void GuiView::errors(string const & error_type, bool from_master)
> {
>      BufferView const * const bv = currentBufferView();
>      if (!bv)
>          return;
> 
>      ErrorList & el = from_master ?
>          bv->buffer().masterBuffer()->errorList(error_type) :
>          bv->buffer().errorList(error_type);
>      if (el.empty())
>          return;
> 
>      string data = error_type;
>      if (from_master)
>          data = "from_master|" + error_type;
>      showDialog("errorlist", data);
> }
> 
> seems to me to make no sense now that we do asynchronous export, at 
> least in so far as it is supposed to be invoked by a signal sent from 
> the processing thread. There is simply no guarantee that the 
> currentBufferView() is the one for which we were doing export. This is 
> the real cause of bug #7152, though adding the if (bv) check at least 
> avoids the crash. I have no idea how to fix this, however.
> 
> Richard
> 

Wouldn't it be a solution to also pass the BufferView to this function?

Peter
-- 
GRATIS! Movie-FLAT mit über 300 Videos. 
Jetzt freischalten unter http://portal.gmx.net/de/go/maxdome

Reply via email to