On Thu, Feb 17, 2011 at 12:20:49AM +0100, Vincent van Ravesteijn wrote: > Op 17-2-2011 0:17, Enrico Forestieri schreef: > >On Wed, Feb 16, 2011 at 11:57:22PM +0100, Vincent van Ravesteijn wrote: > >> Op 16-2-2011 23:19, for...@lyx.org schreef: > >>>Author: forenr > >>>Date: Wed Feb 16 23:19:49 2011 > >>>New Revision: 37704 > >>>URL: http://www.lyx.org/trac/changeset/37704 > >>> > >>>Log: > >>>Don't disable apply button if one (or more) of vertical alignment, > >>>rotation, > >>>or long table settings are changed. Fixes bug #7308. > >>> > >>>Modified: > >>> lyx-devel/trunk/src/insets/InsetTabular.cpp > >>> > >>>Modified: lyx-devel/trunk/src/insets/InsetTabular.cpp > >>>============================================================================== > >>>--- lyx-devel/trunk/src/insets/InsetTabular.cpp Wed Feb 16 22:08:18 > >>>2011 (r37703) > >>>+++ lyx-devel/trunk/src/insets/InsetTabular.cpp Wed Feb 16 23:19:49 > >>>2011 (r37704) > >>>@@ -4323,8 +4323,10 @@ > >>> return true; > >>> > >>> case Tabular::SET_TABULAR_WIDTH: > >>>- status.setEnabled(!tabular.rotate&& > >>>!tabular.is_long_tabular > >>>- && tabular.tabular_valignment == > >>>Tabular::LYX_VALIGN_MIDDLE); > >>>+ status.setEnabled(tabular.tabular_width.zero() > >>>+ || (!tabular.rotate&& > >>>!tabular.is_long_tabular > >>>+ && tabular.tabular_valignment == > >>>+ Tabular::LYX_VALIGN_MIDDLE)); > >>> break; > >>> > >>> case Tabular::SET_DECIMAL_POINT: > >>This is not correct. > >I'm sorry, you're wrong. > > > I'm sorry, I'm right.
You are only a conceited young man. > >>This is basically saying that SET_TABULAR_WIDTH should be allowed > >>for longtables, because tabular_width is zero by definition for > >>longtables. > >It works just fine. > > > It does not. It allows you to execute "inset-modify tabular > set-tabular-width 7cm" for a longtable, and it happily changes the > table, while this lfun should have been disabled. Which has no effect at all. -- Enrico
