On Fri, Mar 29, 2013 at 7:06 AM, Vincent van Ravesteijn <v...@lyx.org> wrote:
> Op 29-3-2013 6:59, Scott Kostyshak schreef:
>
>> On Thu, Mar 28, 2013 at 8:37 AM, Vincent van Ravesteijn <v...@lyx.org>
>> wrote:
>>>
>>>
>>> On Thu, Mar 28, 2013 at 8:19 AM, Scott Kostyshak <skost...@lyx.org>
>>> wrote:
>>>>
>>>> See attached patch.
>>>>
>>>> Before, 'lyx -e pdf2' would give no error and would exit with 0. A use
>>>> case is if a user has in a bash script the following command:
>>>>
>>>> lyx -e pdf2 "${mylxyfile}" || exit 1
>>>>
>>>> where 'lyx' is mispelled as 'lxy' and thus yields an empty
>>>> string. If LyX does not exit with an error, the script continues where
>>>> the user probably intends for it to stop.
>>>>
>>>> Can it go in?
>>>>
>>>> Scott
>>>
>>>
>>> What if the filename is not empty, but the file does not exist ? Does it
>>> exit with an error in that case ?
>>
>> It exits with code 1 but does not display an error message. The
>> attached patch fixes this.
>>
>> Is it OK?
>>
>> Scott
>
> The message should be translated:
>
> docstring const error_message =
> bformat(_("LyX failed to load the following file: %1$s"),
> from_utf8(fname.absFileName()));
> lyxerr << to_utf8(error_message) << endl;
>
> Vincent
Thanks,
Attached is the patch (which I just copied from your code).
Scott
From 3d5a091d166ae5c1377d8423235cfd0334cd7f25 Mon Sep 17 00:00:00 2001
From: Scott Kostyshak <skost...@lyx.org>
Date: Thu, 28 Mar 2013 03:46:35 -0400
Subject: [PATCH] Give an error message when LyX cannot load a file
Before, the following commands correctly exited with code 1, but now
a reason for exiting is also given:
lyx -e pdf2 doesNotExist
lyx doesNotExist -e pdf2
---
src/LyX.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/LyX.cpp b/src/LyX.cpp
index 41def6a..59c314d 100644
--- a/src/LyX.cpp
+++ b/src/LyX.cpp
@@ -507,6 +507,8 @@ bool LyX::loadFiles()
}
else {
pimpl_->buffer_list_.release(buf);
+ lyxerr << "LyX failed to load the following file:\n"
+ << fname.absFileName() << endl;
success = false;
}
}
--
1.7.9.5
