Am Sonntag, 4. August 2013 um 06:27:25, schrieb Scott Kostyshak <skost...@lyx.org> > On Sun, Aug 4, 2013 at 5:12 AM, Kornel Benko <kor...@lyx.org> wrote: > > Am Sonntag, 4. August 2013 um 04:38:20, schrieb Scott Kostyshak > > <skost...@lyx.org> > > > >> On Sun, Aug 4, 2013 at 4:21 AM, Kornel Benko <kor...@lyx.org> wrote: > > > >> > Am Samstag, 3. August 2013 um 17:05:48, schrieb Scott Kostyshak > > > >> > <skost...@lyx.org> > > > >> > > > > >> >> >> I don't agree with the name "revertedTests" (and likewise the > >> >> >> variable > > > >> > > > > >> >> >> names). Using as a reverence > > > >> > > > > >> >> >> http://en.wiktionary.org/wiki/revert > > > >> > > > > >> >> >> I think that you are intending to use it with the following meaning: > > > >> > > > > >> >> >> "(transitive, now rare) To turn back, or turn to the contrary; to > > > >> > > > > >> >> >> reverse." > > > >> > > > > >> > Yes. > > > >> > > > > >> >> >> As noted, this definition is rare. > > > >> > > > > >> >> >> I think most people running the tests will think of git (in fact, > >> >> >> git > > > >> > > > > >> >> >> is mentioned on the wiktionary page) or of this definition: > > > >> > > > > >> >> >> "To cause to return to a former condition." > > > >> > > > > >> >> >> > > > >> > > > > >> >> >> Do you prefer "revert" to "invert"? > > > >> > > > > >> > > > > >> > > > > >> > Of course, if this meaning is rare, I will not prefer it anymore. > > > >> > > > > >> > What I meant was: > > > >> > > > > >> > Show that the named tests are not correct in some way, but that we > > > >> > > > > >> > hope they will be OK some day. > > > >> > > > > >> > In (my) other words: reverted for now. > > > >> > > > >> I see. I can't think of a short way to explain this. > > > >> > > > >> > For me "invertedTests" looks more like we intend let them be forever. > > > >> > > > >> Good point. I didn't think about this. > > > >> > > > >> > But I am not hanging on 'revert'. > > > >> > > > > >> > I knew, *this* will be the hard part. > > > >> > > > >> Indeed. Here's another idea: > > > >> > > > >> INV-TEST_SEE-README.ctest_export/doc/attic/DocStyle_pdf > > > >> > > > >> I don't care about the "INV_TEST" part. That can be any keyword. The > > > >> point is that if someone wants to know what the keyword means it's > > > >> clear to look in README.ctest (or wherever). > > > > > > > > Keep also in mind, that some (possibly short) part of the string should be > > unique. > > > > (I see that INV *is* unique, but INVERTED seems better describing.) > > > > I prefer > > > > INVERTED_SEE-README.ctest_export/doc/attic/DocStyle_pdf > > Sounds good to me. > > > As it is now, testing only _good_ export tests > > > > # ctest -R export -E INVERT > > > > Checking if something is getting better > > > > # ctest -R export -R INVERT > > Looks good. > > Scott
Ok, committed. Someone has to add 'README.ctest'.
Also, your patch
0001-CMake-tests-now-fail-if-no-default_output_format.patch.txt
should go in. (And the relevant tests should be added to revertTests.)
Kornel
signature.asc
Description: This is a digitally signed message part.
