On Sat, Aug 3, 2013 at 3:54 AM, Scott Kostyshak <skost...@lyx.org> wrote: > On Fri, Aug 2, 2013 at 5:58 AM, Vincent van Ravesteijn <v...@lyx.org> wrote: >> >> On Fri, Aug 2, 2013 at 11:45 AM, Kornel Benko <kor...@lyx.org> wrote: >>> >>> > About the patch... why do we care about malformed LyX documents ? How >>> > can >>> >>> > this happen ? Are there some documents in a very old fileformat. Then we >>> >>> > should update those. >>> >>> >>> >>> At least now the tests will show it. >> >> >> >> If this is a valid argument, we can throw in a thousand of ad-hoc checks at >> random places, ... > > I don't consider this an ad-hoc check because I don't view it as a > test for the LyX documents (although as Kornel points out it might > have this extra benefit). I view it as a test of the assumption that > the export tests are making. The export tests depend on finding the > 'default_output_format' buffer param. For the tests to work correctly, > it is assumed that the buffer param exists. This patch tests that > assumption. > > Scott
Vincent, do you have more comments on this? Scott
