Hi Martin, Welcome to the list!
I tested your patch and it works well for me. Does anyone else know whether this is a correct fix? One extra comment that is not directly related to your patch, just in case you are interested in how (in my opinion) bug reports should be handled: The reporter of this bug (me) really reported two things. Thus, it's not a well-written bug report. If your patch is accepted, we should close the bug report and state something like "please open a different bug report for the second issue (putting in a shortcut that already exists)." If it were a serious bug, we should create it ourselves to make sure we don't forget (because once a ticket is closed, it usually slips away into oblivion). If it's more of a feature request that if forgotten it's OK, then we can ask the reporter to do so if desired. Best, Scott On Sat, Oct 5, 2013 at 4:22 PM, Martin Hoffmann <hoffi...@gmail.com> wrote: > Hello all, > > I'm new to this list, and was trying to fix #8703 > (http://www.lyx.org/trac/ticket/8703) according to the manual at > http://www.lyx.org/HowToUseGIT#toc7. The patch is attached. > > What it does: keeps the New Shortcut window open in case of invalid key > sequence or lyx function. > Any comments? > > Regards, > Martin
