Hi,
back from a trip, here a few extra thoughts:
On 01/04/14 08:20, Vincent van Ravesteijn wrote:
> Except that Text::asString(AS_STR_INSETS | AS_STR_PLAINTEXT) now asserts, and
> Paragraph::asString(AS_STR_INSETS|AS_STR_PLAINTEXT) now asserts.
for Paragraphs, there's the comment:
+ /// Convert the paragraph to a string.
+ /// \note If options includes AS_STR_PLAINTEXT, then runparams must be
!= 0
but you're right that for example for Text::asString() this now is not
documented, so we could add the same comment there.
An alternative is of course the one to NOT assert, but simply create a default
OutputParams in that case. Would you prefer something like that? The comment(s)
would be changed into "AS_STR_PLAINTEXT uses the supplied runparams if != 0, or
a default one if none is provided.
> Furthermore, I doubt whether the function behaves as advertised.
that belongs to the subtle differences between those inner Inset methods
(plaintext() vs the other one).
> I'm not going to react to this.
thanks, that was not meant to be anyway serious.
T.
