On 05/16/2014 11:39 PM, Scott Kostyshak wrote:
commit 4bd0941b4fec92354b52bfe82835f7ebb8981d21
Author: Scott Kostyshak <[email protected]>
Date:   Wed Feb 5 17:59:39 2014 -0500

     Graphics only handle inset-modify graphics (#8262)
inset-modify tabular and others are now passed on.

diff --git a/src/insets/InsetGraphics.cpp b/src/insets/InsetGraphics.cpp
index 70b43c4..08d7e82 100644
--- a/src/insets/InsetGraphics.cpp
+++ b/src/insets/InsetGraphics.cpp
@@ -240,8 +245,10 @@ bool InsetGraphics::getStatus(Cursor & cur, FuncRequest const 
& cmd,
                FuncStatus & flag) const
  {
        switch (cmd.action()) {
-       case LFUN_INSET_EDIT:
        case LFUN_INSET_MODIFY:
+               if (cmd.getArg(0) != "graphics")
+                       return Inset::getStatus(cur, cmd, flag);

In cases like this, I prefer we add a comment of the form:

    // fall through

to make it clear that what is about to happen is intended.

+       case LFUN_INSET_EDIT:
        case LFUN_INSET_DIALOG_UPDATE:
        case LFUN_GRAPHICS_RELOAD:
                flag.setEnabled(true);

Richard

Reply via email to