This comes up particularly when the user right-clicks on a Note inset. Before, the user could click on the same type of Note and the document would be marked as dirty, even if nothing changed.
With the patch, if you right-click on the note, the "note" part with the checkmark will be greyed out. I think that makes it more clear (the user will realize "I can't click on that because that's what it already is"), but I wanted to check here first. Any objections? Scott
From 51bc93163ca5d2b7aa4ee73c1bd42b551831d745 Mon Sep 17 00:00:00 2001 From: Scott Kostyshak <[email protected]> Date: Wed, 12 Nov 2014 00:06:46 -0500 Subject: [PATCH] Do not enable switching notes to same type This comes up particularly when the user right-clicks on a Note inset. Before, the user could click on the same type of Note and the document would be marked as dirty, even if nothing changed. --- src/insets/InsetNote.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/insets/InsetNote.cpp b/src/insets/InsetNote.cpp index 6bb294d..cbec02a 100644 --- a/src/insets/InsetNote.cpp +++ b/src/insets/InsetNote.cpp @@ -182,6 +182,7 @@ bool InsetNote::getStatus(Cursor & cur, FuncRequest const & cmd, InsetNoteParams params; string2params(to_utf8(cmd.argument()), params); flag.setOnOff(params_.type == params.type); + flag.setEnabled(params_.type != params.type); } return true; -- 1.9.1
