Re: [LyX/master] GuiBox.cpp: fix button logic (fixes bug #9543)

[Kornel Benko]

Am Sonntag, 10. Mai 2015 um 15:54:07, schrieb Uwe Stöhr <uwesto...@lyx.org>
> commit 4be4d4e1a6d707fe10025e5e4f75e23a8f91edb8
> Author: Uwe Stöhr <uwesto...@lyx.org>
> Date:   Sun May 10 15:54:03 2015 +0200
> 
>     GuiBox.cpp: fix button logic (fixes bug #9543)
> 
> diff --git a/src/frontends/qt4/GuiBox.cpp b/src/frontends/qt4/GuiBox.cpp
> index 66912e8..60a26cd 100644
> --- a/src/frontends/qt4/GuiBox.cpp
> +++ b/src/frontends/qt4/GuiBox.cpp
> @@ -142,8 +142,9 @@ void GuiBox::on_typeCO_activated(int index)
>                       heightCB->setChecked(false);
>               setSpecial(ibox);
>       }
> -     widthCB->setChecked(itype != "none");
>       if (type != "Boxed")
> +             if (type != "Frameless")
> +                     widthCB->setChecked(itype != "none");
>               pagebreakCB->setChecked(false);
>       changed();
>  }

The indentation looks wrong. Why don't you use '{' and '}' to make clear what 
is meant?

Do you mean:
if (type != "Boxed") {
        if (type != "Frameless")
                widthCB->setChecked(itype != "none");
}
pagebreakCB->setChecked(false);

or:
if (type != "Boxed") {
        if (type != "Frameless")
                widthCB->setChecked(itype != "none");
        pagebreakCB->setChecked(false);
}

??

        Kornel

        

signature.asc
Description: This is a digitally signed message part.