On 06/12/2015 11:15 AM, Enrico Forestieri wrote:
On Thu, Jun 11, 2015 at 08:59:39PM -0400, Richard Heck wrote:
On 06/11/2015 11:10 AM, Enrico Forestieri wrote:
On Thu, Jun 11, 2015 at 09:11:30AM -0400, Richard Heck wrote:
On 06/11/2015 04:05 AM, Enrico Forestieri wrote:
On Wed, Jun 10, 2015 at 07:45:46PM +0200, Enrico Forestieri wrote:
commit 21e908b8c49f0b5a7df1eca9b36d2632e0838880
Author: Enrico Forestieri <for...@lyx.org>
Date: Wed Jun 10 19:21:27 2015 +0200
Delay regeneration of previews on zoom changes
Until now the regeneration process was starting as soon as the zoom scale
factor was changed. This was causing some glitches, especially if the zoom
was changed by the mouse wheel, as on each change the process was started
again and again making zoom changes painful and causing races such that
one could end up with the text at some zoom factor and the previews at
another one. After this commit, the regeneration is started only after
the zoom factor has been stable for about 1 second. In this way, one can
use the mouse wheel for changing back and forth the zoom factor at own's
heart desire without any slow down due to the regeneration process running
in the background. For those using previews with numbered math equations,
a nice possibility for getting the equations correctly numbered in sequence
(after removing or adding an equation) is using the shortcuts Alt+ and Alt-
in rapid sequence (less than a second between the keystrokes). Previously,
this would have triggered twice the regeneration, but now only once.
Richard, the attached would be the corresponding patch for stable.
I have been testing it quite heavily and it seems to work w/o glitches.
Do you think this should go to 2.1.4, or should we wait for 2.1.5, so it can
be tested a bit more? This is not a regression, right?
I fear that the slow down caused by the regeneration of the previews
on zoom changes may be perceived as a regression or at least as a
nuisance. Other than that, I have no problem waiting for 2.1.5.
OK, well, if you think it's safe, then go ahead.
I feel pretty sure this won't cause problems and committed it. Without
this, changing the zoom when the regeneration takes some time could be
annoying. For example, this would be the case with our instant preview
example which involves using xypic, tipa, pstricks, and tikz examples.
With this change, one can rapidly change the zoom factor without issues.
OK, then, and thanks for all your work on this.
Richard
