Op 12-10-2015 om 4:17 schreef Scott Kostyshak:
On Sun, Oct 11, 2015 at 11:20:15AM +0200, Georg Baum wrote:
commit cea2d71e641e6a4023128a367d1cd5a593ed1706
Author: Georg Baum <b...@lyx.org>
Date: Sun Oct 11 11:16:09 2015 +0200
Comply with rule-of-three
The rule-of-three says that if any of virtual destructor, copy constructor
or assignment operator needs to be manually implemented, then all three
should be implemented. Otherwise you can get subtle bugs which can be
difficult to find. In the changed classes, changing a copy-construction to
an assignment would have had surprising effects. Now they all behave
consistently.
What about declaring the unimplemented 'others' as private, but leaving
them unimplemented (if possible) ? This prevents adding unused code to
the codebase.
I've seen that approach to comply to the rule.
Vincent
