On 7 Feb 2001, Lars Gullik Bjønnes wrote:
> | + int height = vbt->DefaultHeight();
> | + int first = static_cast<int>((bv_->text->first + height));
> | + int last = static_cast<int>((bv_->text->first +
> | workarea_->height() - height));
>
> Can these int be const? If so make them so.
OK
> | + if (int(value) == 0) return 0;
>
> Wouldn't it be more natural to do "if (value == 0.0)", than using a
> cast?
It would be more natural to not compare floating point values using ==
...
I'll back these bits out none the less
> | + * Timeout.C
> | + * (C) 2001 LyX Team
> | + * John Levon, [EMAIL PROTECTED]
>
> ha!
>
Very sorry, I didn't mean to imply anything by this.
How should I write it ?
I put my name there so someone knows who to blame, like I have all the others.
Should I just leave out name + email all together ? Comment please
> | +Timeout::Pimpl::~Pimpl()
> | +{
> | +}
>
> Do you really need this?
> Remove if possible.
ok
thanks
john
--
"Beware of bugs in the above code; I have only proved it correct, not tried it."
- Donald Knuth
