On Sun, Nov 15, 2015 at 12:18:28PM -0500, Richard Heck wrote: > On 11/15/2015 12:05 PM, Jean-Marc Lasgouttes wrote: > > Le 14/11/2015 05:13, Scott Kostyshak a écrit : >> I have tagged and tarred > > (and signed) alpha1. I will upload the > tarballs >> soon. >> >> Development is open for post-alpha commits. > > > So can we just commit as we see fit, or would you like stuff to go to > mailing list first? > > I would suggest we move at this point to the rule we've used before. All > non-trivial patches must go to the list and get the approval of at least > one other developer. Once we get a further into the process, we could > switch to the stricter condition that they need Scott's approval in > particular.
Thanks for this proposal Richard. Sounds good to me. There will be many patches that I do not understand so I will be confident if they receive a +1 from another developer. > Along those lines: The idea behind your patch looks fine to me. The following is not a critique (so please push because of Richard's positive feedback), but if you have time I am curious about the following: strwidth_cache_(1 << 19) How did you decide on 19? And why the trick of 1 << 19 instead of just the following? strwidth_cache_(19) I'm guessing this is a C++ trick I should know. Scott
signature.asc
Description: PGP signature