Am 20.12.2015 um 12:31 schrieb Kornel Benko:
Am Sonntag, 20. Dezember 2015 um 12:10:19, schrieb Peter Kümmel
<syntheti...@gmx.net>
Am 20.12.2015 um 11:29 schrieb Georg Baum:
Kornel Benko wrote:
Setting SRC_LIBCHARSET in the patch might be guarded by:
if(UNIX AND NOT MINGW)
endif()
But since I cannot test windows or Mac I don't commit.
You will see here if it compiles here:
https://travis-ci.org/syntheticpp/lyx
I'd say commit. If relocatable.c is not supposed to be compiled, then it
should be removed from the sources, these are stripped down anyway. If this
really results in an error on windows then somebody will notice.
These libs are only supposed to be built with mingw or MSVC, except
hunspell: On linux and OS X they are already provided by the OS. iconv is
even part of libc on linux. We should probably split the LYX_3RDPARTY_BUILD
switch so that the bundled hunspell can also be used independently from the
two other libs.
So which logic we should use?
1. iconv and zlib must not build on Linux
2. LYX_3RDPARTY_BUILD triggers only hunspell build and usage on Linux,
even when there is a system version of hunspell
I committed 2.) for now.
Or is it better to disable all three libs on Linux?
Is there any benefit to use the bundled libs?
I do not see the benefit for linux ATM. But it does not harm and maybe in future
we could add some really needed 3rdparty sources.
BTW, shouldn't boost be 3rdparty too?
Yes, but I didn't want change too much at once.
But now I've moved boost to 3rdparty.
And updated to 1.60.
Peter
