Le 20/01/2016 14:57, Enrico Forestieri a écrit :
On Wed, Jan 20, 2016 at 02:05:31AM -0500, Guillaume Munch wrote:
Le 19/01/2016 18:42, Enrico Forestieri a écrit :
On Tue, Jan 19, 2016 at 05:19:24PM -0500, Scott Kostyshak wrote:
On Sat, Jan 16, 2016 at 04:41:26PM +0100, Enrico Forestieri wrote:
commit 55b3374f3e3047a0aa7584e0737d1fcd40fe6809
Author: Enrico Forestieri <for...@lyx.org>
Date: Sat Jan 16 16:41:04 2016 +0100
Always place the cursor before a separator inset when clicking
Note that this commit might have triggered the assertion #9936.
Thanks. The attached patch fixes it for me.
You have added similar lines at several other places recently, after my
remarks. Should they be amended similarly?
No, the cursor is already in texted there.
Also, would it be better if you
factored the shared code in a new function?
They are only 2 lines of code, after all.
I think factoring the code is preferable in this situation. It
makes the code easier to understand and maintain. Also, it would check
for texted in all cases so it would depend on less assumptions. But I
also understand that you are very busy currently. I trust that you are
confident that no additional check for texted is required.
Guillaume
