Le 06/06/16 à 21:04, Guillaume Munch a écrit :
Le 06/06/2016 10:22, Jean-Marc Lasgouttes a écrit :
Le 05/06/2016 à 13:54, Georg Baum a écrit :
Looks good, I have only one minor comment: Please do not use _MSC_VER
in the
sources. This code is better located in config.h, like that:
#if (__cplusplus >= 201402L) || (defined(_MSC_VER)&&(_MSC_VER>=1800))
// C++14, MSVC >= 2013
#define HAVE_STD_MAKE_UNIQUE
#endif
What about testing for std::make_unique instead?
You mean during configure?
Yes. If we want, say, to be ale to compile for some intel compiler, it
is better.
JMarc
