On Tue, Jun 14, 2016 at 06:19:27PM +0000, Paul A. Rubin wrote: > Scott Kostyshak <skostysh <at> lyx.org> writes: > > > > > Does anyone else see that the radio buttons are cut-off on the message > > pane? > > > > FWIW, they're find with LyX 2.2.0 /Qt 4.8.6 on Linux Mint Rebecca. > > Paul
I forgot to mention: when testing you should try to make the height of the messages pane as small as possible. Does it allow you to go "too" small? Attached is a patch. I've tested docking it, undocking it, and resizing it in weird ways. I link below to before/after screenshots with Qt 4 and Qt 5 and two different systems (both Ubuntu though): https://www.dropbox.com/s/rysu6whqg8h87z5/qt4_15_after.png?dl=0 https://www.dropbox.com/s/bambj1hlkxwdhrm/qt4_15_before.png?dl=0 https://www.dropbox.com/s/xtiryrxhoq7ht02/qt5_13_after.png?dl=0 https://www.dropbox.com/s/sxjwrno7xe347a5/qt5_13_before.png?dl=0 https://www.dropbox.com/s/o85jugavc62fk7l/qt5_15_after.png?dl=0 https://www.dropbox.com/s/7zfbgfatvvssh55/qt5_15_before.png?dl=0 I've tested with Arabic, French, and German. The patch solves two issues: 1. gets rid of the issue with the radio buttons that I posted about. 2. makes room for both the "Outline" and "Settings" tab names to show, so there is no clipping and the arrows are not needed (did other people see this issue as well or just me?). The second issue that is solved is partly by luck, and that is good. That is to say, the vertical size is not determined based on the tab names. Thus the bad news is that the little arrows that annoy me could come back (i.e. this change is not robust). The good news is that we do not have to be worried that there are translations with long names for the tab names that would make the vertical size extremely large. The disadvantage of the patch is that the minimum size required is now larger than before. Perhaps some people not as bothered as I was by the two issues I mention above prefer to have the smaller vertical size. I attempted to make it so that the widget containing the list of debug levels (named "outTE") was not important in determining the size (there is a scrollbar anyway), but I failed to figure this out. I did my testing on a 13-inch screen and the increase did not bother me at all so I don't expect others to mind it, but I bring this up just in case. As for the patch itself, I don't know much about ui files so I am proposing it mostly based on the "it works for me" principle. From what I understand, many editors of the ui files before me have used the same principle. My approach was to remove some numbers that seemed arbitrary to me. Any objection? Scott
From 3c19a922d384b6544434bfdd74a4f44538853326 Mon Sep 17 00:00:00 2001
From: Scott Kostyshak <skost...@lyx.org>
Date: Tue, 14 Jun 2016 16:42:25 -0400
Subject: [PATCH] Fix two UI issues in the messages pane
1. sets the correct height for the radio buttons to avoid clipping
2. makes room for both the "Outline" and "Settings" tab names to
show, so there is no clipping and the arrows are not needed.
The second issue above is solved partly by luck, and that is good.
That is to say, the vertical size is not determined based on the tab
names. Thus the bad news is that the little arrows could come back
when we make future changes to this ui file (i.e. this change is not
robust). The good news is that we do not have to be worried that
there are translations with long names for the tab names that would
make the vertical size of the widget extremely large.
The disadvantage of this patch is that the minimum size required by
the messages pane is now larger than before. Perhaps some people not
as bothered as I was by the two issues I mention above prefer to
have the smaller vertical size. I attempted to make it so that the
widget containing the list of debug levels (named "outTE") was not
important in determining the size (there is a scrollbar anyway), but
I failed to figure this out.
---
src/frontends/qt4/ui/ProgressViewUi.ui | 54 ----------------------------------
1 file changed, 54 deletions(-)
diff --git a/src/frontends/qt4/ui/ProgressViewUi.ui
b/src/frontends/qt4/ui/ProgressViewUi.ui
index 1ae1c6d..356d2ad 100644
--- a/src/frontends/qt4/ui/ProgressViewUi.ui
+++ b/src/frontends/qt4/ui/ProgressViewUi.ui
@@ -4,40 +4,6 @@
<exportmacro></exportmacro>
<class>ProgressViewUi</class>
<widget class="QWidget" name="ProgressViewUi" >
- <property name="geometry" >
- <rect>
- <x>0</x>
- <y>0</y>
- <width>543</width>
- <height>298</height>
- </rect>
- </property>
- <property name="sizePolicy" >
- <sizepolicy>
- <hsizetype>7</hsizetype>
- <vsizetype>13</vsizetype>
- <horstretch>0</horstretch>
- <verstretch>0</verstretch>
- </sizepolicy>
- </property>
- <property name="minimumSize" >
- <size>
- <width>0</width>
- <height>0</height>
- </size>
- </property>
- <property name="sizeIncrement" >
- <size>
- <width>0</width>
- <height>0</height>
- </size>
- </property>
- <property name="baseSize" >
- <size>
- <width>0</width>
- <height>0</height>
- </size>
- </property>
<property name="windowTitle" >
<string/>
</property>
@@ -53,20 +19,6 @@
<property name="enabled" >
<bool>true</bool>
</property>
- <property name="sizePolicy" >
- <sizepolicy>
- <hsizetype>7</hsizetype>
- <vsizetype>13</vsizetype>
- <horstretch>0</horstretch>
- <verstretch>0</verstretch>
- </sizepolicy>
- </property>
- <property name="baseSize" >
- <size>
- <width>0</width>
- <height>0</height>
- </size>
- </property>
<property name="acceptDrops" >
<bool>false</bool>
</property>
@@ -106,12 +58,6 @@
<verstretch>0</verstretch>
</sizepolicy>
</property>
- <property name="maximumSize" >
- <size>
- <width>16777215</width>
- <height>16777215</height>
- </size>
- </property>
<property name="frameShape" >
<enum>QFrame::StyledPanel</enum>
</property>
--
2.1.4
signature.asc
Description: PGP signature
