On 07/10/2016 07:06 AM, Guillaume Munch wrote: > Le 10/07/2016 06:42, Richard Heck a écrit : >> On 07/10/2016 01:33 AM, Scott Kostyshak wrote: >>> On Sun, Jul 10, 2016 at 07:16:13AM +0200, Richard Heck wrote: >>>> commit d8aab4af9e6e72c835f78ba54a46687b870c25fa >>>> Author: Richard Heck <rgh...@lyx.org> >>>> Date: Sun Jul 10 01:12:42 2016 -0400 >>>> >>>> Fix thinko in Buffer::preview. It is possible for this routine to >>>> be called when we do not have a cloned Buffer, namely, if we >>>> do not >>>> have EXPORT_in_THREAD defined. >>> Thanks for fixing this. How does one set EXPORT_in_THREAD? I imagine >>> this could be useful for debugging purposes (e.g ruling out that a bug >>> is due to exporting in a separate thread). >> >> It's #defined in GuiView.cpp and GuiAlert.cpp. It's set in the code, but >> can be manually unset by people who don't want the risks of background >> export, threading, etc. And yes, it is useful for the purpose you >> mentioned. >> > > Note that one of the file erroneously tests with #ifdef instead of #if, > so I doubt that it has ever been unset. (This is fixed by my patch at > <http://mid.gmane.org/nlbl32$hki$2...@ger.gmane.org>.)
I noticed that, too. Certainly that can be fixed independently of the rest (which is fine by me, too). Richard
