On 12/02/2016 07:05 PM, Enrico Forestieri wrote: > On Fri, Dec 02, 2016 at 12:27:03AM +0100, Enrico Forestieri wrote: >> On Thu, Dec 01, 2016 at 04:31:44PM -0500, Richard Heck wrote: >>> I'm no expert on this part of the code, but this doesn't look too >>> dangerous. Since 2.2.3 is still a little ways away, is it worth >>> committing to stable? >> I think it is not risky and I am attaching the version for stable here. >> However, it behaves a bit differently than in trunk, as the braces that >> are added when the macro appears in the argument of another macro are >> preserved on copy/paste. > I found the what is the problem here, and it is quite embarassing... > In trunk, WriteStream has only a constructor, while in stable it has two. > I had not realized this when backporting, so that the insidemacro_ member > was being initialized only in one of the constructors, causing the issue. > Note that I made the same mistake at 8a1f936f, which has to be corrected, > too. I am attaching here a revised backport that works as expected.
Looks good to me. Richard
