On Thu, Jun 01, 2017 at 01:24:35PM -0400, Scott Kostyshak wrote: > On Fri, May 05, 2017 at 08:30:51AM +0200, Tommaso Cucinotta wrote: > > commit 0cf394dd79337b14adb2930a617c2027e0d6f2d8 > > Author: Tommaso Cucinotta <tomm...@lyx.org> > > Date: Thu May 4 07:49:07 2017 +0200 > > > > skip graphics conversion when runparams.dryrun is true > > After this commit, if I copy a selection that has an image in it, I get > the following message: > > insets/InsetGraphics.cpp (956): InsetGraphics::xhtml: Unable to prepare file > `/home/scott/lyxbuilds/2017-05-17/repo/lib/images/buffer-write.svgz' for > output. File missing? > > Attached is a patch but I have no idea if it's correct.
I think the problem is in the commit itself, which contains only this change: - string const output_file = prepareHTMLFile(op); + string const output_file; + if (!op.dryrun) + prepareHTMLFile(op); So, output_file is always empty, whatever op.dryrun. I think that the following change was instead meant: - string const output_file = prepareHTMLFile(op); + string const output_file = op.dryrun ? string() : prepareHTMLFile(op); -- Enrico
