Am Samstag, 16. Dezember 2017 um 07:03:34, schrieb Pavel Sanda <sa...@lyx.org>
> Richard Heck wrote:
> > commit b684ec39eaaf7d5b0270bf8109b8e281fa8c5d9f
> > Author: Richard Heck <rgh...@lyx.org>
> > Date: Fri Dec 15 23:50:23 2017 -0500
> >
> > Fix #10863 compiler warnings.
> > ---
> > src/mathed/MathParser.cpp | 12 +++++-------
> > 1 files changed, 5 insertions(+), 7 deletions(-)
> >
> > diff --git a/src/mathed/MathParser.cpp b/src/mathed/MathParser.cpp
> > index 35062ca..c914a6a 100644
> > --- a/src/mathed/MathParser.cpp
> > +++ b/src/mathed/MathParser.cpp
> > @@ -744,7 +744,6 @@ docstring Parser::parse_verbatim_option()
> > skipSpaces();
> > docstring res;
> > if (nextToken().character() == '[') {
> > - Token t = getToken();
> > for (Token t = getToken(); t.character() != ']' && good(); t =
> > getToken()) {
> > if (t.cat() == catBegin) {
> > putback();
> > @@ -762,7 +761,6 @@ docstring Parser::parse_verbatim_item()
> > skipSpaces();
> > docstring res;
> > if (nextToken().cat() == catBegin) {
> > - Token t = getToken();
> > for (Token t = getToken(); t.cat() != catEnd && good(); t =
> > getToken()) {
> > if (t.cat() == catBegin) {
> > putback();
>
> I don't see wider context, but it seems the new codes has one less getToken()
> call.
> Doesn't it have some side effect? P
It has:
# ctest -R 'EmbeddedObjects_(pdf|dvi)'
==> 36 tests failed out of 45
If reverting this calls (using "(void) getToken();")
# ctest -R 'EmbeddedObjects_(pdf|dvi)'
==> 3 tests failed out of 45
The following tests FAILED:
294 - DEFAULTOUTPUT_export/export/latex/EmbeddedObjects_pdf2
(Failed)
297 -
DEFAULTOUTPUT_export/export/latex/MWE_EmbeddedObjects_pdf2 (Failed)
1512 - export/doc/EmbeddedObjects_pdf (Failed)
Errors while running CTest
which is too much too, because before the patches there was no error.
Kornel
signature.asc
Description: This is a digitally signed message part.
