On Thursday, 1 February 2018 19.09.47 WET Scott Kostyshak wrote: > Thanks to Jean-Pierre's hawk eyes, we found a potential issue in > configure.py [1]. I did not see this because I don't manually check the > configure log (although this would be a good thing to do from time to > time). > > I'm wondering if it would be useful to add an option to configure.py > that would turn warnings into errors; and additionally whether it would > make sense to turn this option on by default when using > --enable-build-type=pre (autotools) and -DLYX_RELEASE=OFF (CMake). > > Thoughts? > > Scott > > > [1] > https://www.mail-archive.com/search?l=mid&q=c8e8f5aa-e4fa-4daa-dba2-a4d7435b > 39a6%40free.fr
What are the cases where a bigger warning is expected? I am asking this because I intend to look into it because I have a huge itch there, Fedora uses xdg-open to select the default viewers. For the moment we have been patching the file, we have the following comment in the rpm spec file: ## upstreamable patches # submitted, but upstream rejected it. we currently agree to disagree. Patch50: lyx-2.2.3-xdg_open.patch This is cumbersome as every time there is a new release we need to redo the patch if configure.py has changed. My idea was to have some kind of plug in architecture where each platform allows a set of defaults and to use different orders. As an example take the pdf viewer where we search for: ['pdfview', 'kpdf', 'okular', 'qpdfview --unique', 'evince', 'xreader', 'kghostview', 'xpdf', 'SumatraPDF', 'acrobat', 'acroread', 'mupdf', 'gv', 'ghostview', 'AcroRd32', 'gsview64', 'gsview32'] we do this regardless of the platform. So if you have any suggestions regarding configure.py I can easily look into them. Regards, -- José Abílio
