On 4/20/19 1:47 PM, Juergen Spitzmueller wrote: > commit 0a4686d8d345e7d2924bf990e99d957f045d581e > Author: Juergen Spitzmueller <sp...@lyx.org> > Date: Sat Apr 20 19:53:24 2019 +0200 > > update buffer after fixBiblio > > fixes: #2743 > --- > src/Paragraph.cpp | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/src/Paragraph.cpp b/src/Paragraph.cpp > index 4e36f7f..e5327a4 100644 > --- a/src/Paragraph.cpp > +++ b/src/Paragraph.cpp > @@ -3723,6 +3723,8 @@ int Paragraph::fixBiblio(Buffer const & buffer) > insertInset(0, inset, font, Change(track_changes ? Change::INSERTED > : Change::UNCHANGED)); > > + // This is needed to get the counters right > + buffer.updateBuffer(); > return 1; > }
I am guessing this will be fine, but just so we're all on the lookout: There have been cases where we're just 'not ready' for updateBuffer. That's why we have the machinery to defer doing that until the end of some other process. So if we start seeing crashes in certain cases, it'd be worth looking here. Riki
